Refactor pipeline mode handling with strategy pattern and harden retrieval imports#52
Draft
cursor[bot] wants to merge 2 commits intodevelopmentfrom
Draft
Refactor pipeline mode handling with strategy pattern and harden retrieval imports#52cursor[bot] wants to merge 2 commits intodevelopmentfrom
cursor[bot] wants to merge 2 commits intodevelopmentfrom
Conversation
Co-authored-by: Christian <ChrisCoder9000@users.noreply.github.com>
Co-authored-by: Christian <ChrisCoder9000@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/config.pyusing a single_read_mode()path and explicit allowed mode sets.src/core/pipeline/mode_strategy.pyand reused it from both ingestion entry points.pipeline_modebranching insrc/workers/tasks/ingestion.pyandsrc/core/saving/auto_kg.pywith strategy dispatch.MODEL_MODESfrom config insrc/core/instances.py.retrievecontroller import behavior by deferring heavy imports (kg_agent, NER extractor) to function scope to reduce import-time failure points.Design Patterns Applied
Strategy:PipelineModeStrategyimplementations forlightweightandaccuratebehavior.Factory Method:PipelineModeStrategyFactory.create()selects strategy by mode.Tests
tests/test_config_pipeline_mode_refactors.pycovering:PIPELINE_MODE,OCR_MODE,AGENTIC_ARCHITECTURE)python3 -m pytest -q52 passed, 1 warningCommits
5dc8549Refactor pipeline mode handling with strategy factory4db81d7Defer heavy retrieve imports and stabilize architecture stubs